ref: Remove board types, refactoring

server/api/controllers/board-memberships/create.js

@@ -68,8 +68,15 @@ module.exports = {
 
     const values = _.pick(inputs, ['role', 'canComment']);
 
-    const boardMembership = await sails.helpers.boardMemberships
-      .createOne(values, user, board, this.req)
+    const boardMembership = await sails.helpers.boardMemberships.createOne
+      .with({
+        values: {
+          ...values,
+          board,
+          user,
+        },
+        request: this.req,
+      })
       .intercept('userAlreadyBoardMember', () => Errors.USER_ALREADY_BOARD_MEMBER);
 
     return {

server/api/controllers/board-memberships/delete.js

@@ -36,15 +36,15 @@ module.exports = {
       );
 
       if (!isProjectManager) {
-        throw Errors.BOARD_MEMBERSHIP_NOT_FOUND;
+        throw Errors.BOARD_MEMBERSHIP_NOT_FOUND; // Forbidden
       }
     }
 
-    boardMembership = await sails.helpers.boardMemberships.deleteOne(
-      boardMembership,
+    boardMembership = await sails.helpers.boardMemberships.deleteOne.with({
       project,
-      this.req,
-    );
+      record: boardMembership,
+      request: this.req,
+    });
 
     if (!boardMembership) {
       throw Errors.BOARD_MEMBERSHIP_NOT_FOUND;

server/api/controllers/board-memberships/update.js

@@ -44,11 +44,11 @@ module.exports = {
 
     const values = _.pick(inputs, ['role', 'canComment']);
 
-    boardMembership = await sails.helpers.boardMemberships.updateOne(
-      boardMembership,
+    boardMembership = await sails.helpers.boardMemberships.updateOne.with({
       values,
-      this.req,
-    );
+      record: boardMembership,
+      request: this.req,
+    });
 
     return {
       item: boardMembership,